Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE: $.markup doesn't handle {{highlight:x}} properly #28

Open
colinStevenson opened this issue Jul 12, 2017 · 1 comment
Open

IE: $.markup doesn't handle {{highlight:x}} properly #28

colinStevenson opened this issue Jul 12, 2017 · 1 comment

Comments

@colinStevenson
Copy link
Contributor

The formats for empty and error render "No results found for" rather than "No results found for x" - IE doesn't seem to handle document fragments properly. You can update the templates to wrap in a span as a hack but as is, these dont render properly in IE.

@micha3ldavid
Copy link

The markup method has two statements it can go into - one using Templates (everybody but IE) and a fallback method for IE. that fallback loops a fragement and pulls out the child nodes. The logic for that may need to change to check for both text nodes and child nodes would be my guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants