Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hideOnStill functionality #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

browndp08
Copy link

Users now have the ability to hide the scroll button when scrolling ends.

Users now have the ability to hide the scroll button when scrolling ends.
@markgoodyear
Copy link
Owner

Thanks for the PR, quite like this feature. Would you be able to follow the code style to keep the code base the same throughout? For example, indentation should follow the current 4 space (not tab) indentation. Also checkout the contribution doc for info on how build out the distribution files — I can do this though!

@browndp08
Copy link
Author

Absolutely. I'll note that for the future.

@aagouda
Copy link

aagouda commented Jan 22, 2015

This PR must be add, very important.

@jacklj
Copy link

jacklj commented Jan 31, 2015

Yes, would be great to get this added. Tiny bug (feature?), if no scrolling has taken place, and the page is already scrolled down (e.g. if you scroll down, then go to another page then press the browser's back button so that the page is returned to at it's previous scrolled-to location), then the scroll button doesn't disappear till you scroll for the first time.

@browndp08
Copy link
Author

@markgoodyear I updated the code spacing and used gulp to build the dist folder. Also merged your latest version in. Is there anything else I need to do for you to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants