Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implications of hapi 9.0.0 for MrHorse #16

Closed
devinivy opened this issue Jul 7, 2015 · 4 comments
Closed

Implications of hapi 9.0.0 for MrHorse #16

devinivy opened this issue Jul 7, 2015 · 4 comments
Assignees
Labels

Comments

@devinivy
Copy link
Collaborator

devinivy commented Jul 7, 2015

It looks like hapi is aiming to provide lifecycle hooks on routes: hapijs/hapi#2566. This is wonderful, and will be able to offer performance that is hard to achieve in the form of a plugin due to access to hapi internals. In some ways it's also very validating for MrHorse!

I'm wondering what we think this could mean for the feature-set of MrHorse. If there's a "native" way to add lifecycle hooks per route, the interface/usage/benefits of MrHorse may look quite different in the future! Just wanted to bring this up, and hopefully get some ideas going.

@mark-bradshaw
Copy link
Owner

Thanks for the heads up Devin. That's very interesting. If nothing else it could make it more straightforward for us to hook policies up.

@dlong500
Copy link

So now that hapi v9 is released is this plugin still compatible or are there changes required?

@mark-bradshaw
Copy link
Owner

@dlong500 I haven't tested yet, but I believe it should still work just fine. I'll try to verify tonight.

@mark-bradshaw mark-bradshaw self-assigned this Aug 30, 2015
@mark-bradshaw
Copy link
Owner

@dlong500 Good news. I did a quick test and there's no problems. MrHorse continues to work normally in Hapi 9 with no adjustments needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants