Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect loop when using session cookie same_site strict #116

Open
mintalicious opened this issue Oct 18, 2024 · 0 comments
Open

Redirect loop when using session cookie same_site strict #116

mintalicious opened this issue Oct 18, 2024 · 0 comments

Comments

@mintalicious
Copy link

It's more of a hint than an issue.
After a pentest of our webapp which resulted in a recommendation using SameSite strict for cookies, we encountered an issue by a new user, who has a favorites.html with a link to the webapp. When he tried to get to the app, the request ended in a redirect loop between the callback and login routes and Keycloak.

I found out, that using 'same_site' => 'strict' in config/session.php leads to these redirect loops when the request of the page originates from a hyper link. The reason seems to be the session handling of Laravel (laravel/framework#31442 (comment)).
So we changed back to SameSite lax.

Maybe, this could be mentioned in the FAQs - it took me half a day to find that out.

Regards
Erik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant