Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a common base for all themes #2002

Closed
5 tasks
sebald opened this issue Apr 14, 2022 · 3 comments
Closed
5 tasks

Use a common base for all themes #2002

sebald opened this issue Apr 14, 2022 · 3 comments
Labels
status:ready Ready for development type:feature New feature or component type:refactoring Refactoring required

Comments

@sebald
Copy link
Member

sebald commented Apr 14, 2022

Description

It is obnoxious to use stuff like grey40 and make sure it is used for every border and stuff like this. We need a more semantic design tokens!

Tasks:

  • Update createTheme with semantic colors
  • Update b2b-theme (use createTheme)
  • Update core-theme (use createTheme)
  • Update unicorn-theme (use createTheme)
  • Update docs-theme (use createTheme)

Semantic Colors:

  • colors
    • text
    • background
    • primary
    • secondary
    • disabled
    • error
    • warning
    • info
    • success
  • fonts
    • body
    • heading

Context

We already started the work with @margiold/create-theme we need to add some more features and make it more usable.

Consequences

Helps maintain a common base for theme with sensible defaults.
@sebald sebald added type:feature New feature or component status:ready Ready for development type:refactoring Refactoring required labels Apr 14, 2022
@sebald sebald mentioned this issue Apr 14, 2022
Closed
3 tasks
@sebald sebald pinned this issue Apr 14, 2022
@sebald sebald mentioned this issue Apr 24, 2022
Closed
8 tasks
@sebald sebald changed the title Use a common base for alle themes Use a common base for all themes Apr 24, 2022
@sebald sebald unpinned this issue Apr 29, 2022
@sebald
Copy link
Member Author

sebald commented Jul 18, 2022

Do #2153 before this?

@sebald
Copy link
Member Author

sebald commented Sep 28, 2022

I don't think this is a good idea anymore. We tried this for the docs and it makes it much harder to look up available tokens 😐

@sebald sebald closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
@benediktgrether
Copy link
Contributor

benediktgrether commented Oct 12, 2022 •
edited
Loading

  • Check colors of the components.
  • Define how semantic colors can be used.

https://medium.com/getaround-eu/colors-that-make-sense-505d0f3509c1
https://zeroheight.com/9f0258bf8/p/30935a-color/b/1782cf

@sarahgm sarahgm moved this to Todo in 📝 Planning Board Nov 10, 2022
@sarahgm sarahgm moved this from Todo to In Progress in 📝 Planning Board Nov 10, 2022
@sebald sebald closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2022
Repository owner moved this from In Progress to Done in 📝 Planning Board Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready Ready for development type:feature New feature or component type:refactoring Refactoring required
Projects
📝 Planning Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebald @benediktgrether