-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trivial spelling errors #220
Conversation
ottok
commented
Mar 11, 2023
•
edited
Loading
edited
- handshak -> handshake
- occured -> occurred
- releated -> related
- reponse -> response
- seperated -> separated
- sucess -> success
- use use -> use
Travis CI failed on mtr test |
Hi! This has been open for two weeks. The topic itself is fairly trivial. Can you please merge or give feedback what changes you wish to see in it? |
Rebased on latest 3.3. CI tests are failing on issues that are not due to this PR but already regressed on mainline (missing grants, SQL procedure syntax errors, missing test data file etc). Merging this PR is safe. |
@LinuxJedi Could you please review and merge this? The MariaDB Connector C is embedded in the MariaDB Server which the Foundation publishes. |
As this is a MariaDB Corporation project, I do not have sufficient privileges to do so. |
man pages are created from Wiki with pandoc markdown to man converter. |
- handshak -> handshake - occured -> occurred - releated -> related - reponse -> response - seperated -> separated - sucess -> success - use use -> use All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
I rebased this now on latest 3.3. Can you @9EOR9 please merge this? The fixes are trivial spelling fixes and the PR has been open for a year now. It should not matter if the man pages are copied from elsewhere, this PR still fixes them in the target for now and there is no downside to it. |
Sorry being bit late in party but could man pages regenerated with newer pandoc as it would fix warnings like:
According to this jgm/pandoc#9020 |
@ottok All these bugs have been fixed in Connector/C Github Wiki. I recently fixed the creation of manpages and pushed it into 3.3 (now cmake options -DWITH_DOCS=ON should build man pages if python3 and doxygen are installed). The typo in result test was fixed too, however there was a missing underscore, not a double "use". |
For the record, the man pages continue to have the spelling errors on the 3.3 branch as this PR was not merged. For the 3.4 branch the man pages were updated in e06ff35 which brought in most of the spelling fixes. |