Deployment on https://www.romhacking.net/patch does not work on iOS

[jackharro]

G'day,

I'm trying to patch this hack. I don't have my computer on me at the moment so I'm trying to use a website on my iPad.

I upload the ROM as a .gb, but I have to upload the patch renamed with an extension other than .ips due to iOS restrictions. My guess is that it failed because of this.

The JavaScript could also be unfriendly to iOS.

Fixes

My suggestion is to remove any checks of the extension. I don't know how you'd troubleshoot anything else.

Error response:
Unknown.html.txt

(on iOS, I can't select html files. Excuse the extension.)

Software:
iOS 16.5
Firefox

[jackharro]

This is what the one at https://www.marcrobledo.com/RomPatcher.js/ spat out:

Unknown (4).html.txt

(I can't see the actual page until I upload it to GitHub)

Edit: I can't see what this one looks like in a web browser atm. I'll check when I'm at my computer next.

[jackharro]

As it turns out, the uploading is unique to iPadOS. iPhones can upload .ips files, so that's a separate issue.

This issue still occurs with the correct .ips file.

Let's focus on the other symptoms:

• The served file is listed as 1MB prior to download
• The served file is 1kB in size when downloaded
• The served file is a HTML error page. On https://www.romhacking.net/patch, the header says that is a 404 error.

Here is a video:
https://github.com/user-attachments/assets/cdce62b9-2f2e-4c92-a51d-062f2c667e98

[jackharro]

I just tried with Orion browser and it worked just fine. It would probably also work with Safari and Chrome.

This issue is specific to Firefox.

I'd be content if this issue was filed as wontfix given how not-worth-it troubleshooting browser incompatibility can be.

[marcrobledo]

Can you confirm this is already fixed in v3.0 RC5?

[jackharro]

Hi

Here's a screenshot of the issue:

I just tried Orion again and while I can select the files, it seems to be broken and the result does not download. I will try again on 2.9.

[jackharro]

Follow up: 2.9 now downloads with a jpeg extension, but is a valid .gb file. Unknown if it is properly patched. 3.0 RC5 does not properly supply a blob at all.

[marcrobledo]

Looks like Orion acts like Safari somehow.
There has been a fix lately for Safari which wasn't allowing to choose patch files.

Can you go here and paste here your user agent?

Follow up: 2.9 now downloads with a jpeg extension, but is a valid .gb file. Unknown if it is properly patched. 3.0 RC5 does not properly supply a blob at all.

2.9 hasn't been updated at all, so if it doesn't work now, it never has worked.

[jackharro]