Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mem leak, window resize handler not removed #31

Closed
trusktr opened this issue Mar 14, 2022 · 1 comment · Fixed by #36
Closed

mem leak, window resize handler not removed #31

trusktr opened this issue Mar 14, 2022 · 1 comment · Fixed by #36

Comments

@trusktr
Copy link
Contributor

trusktr commented Mar 14, 2022

window.addEventListener('resize', () => {
this.uniforms.projectionMatrixCamera.value.copy(this.camera.projectionMatrix)
this.saveDimensions()
})

I don't see a dispose method, and that handler is never removed, so instances of this material can not be garbage collected.

@marcofugaro
Copy link
Owner

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants