Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings with React 16.9.0 #83

Open
NicoleRauch opened this issue Aug 18, 2019 · 1 comment
Open

Warnings with React 16.9.0 #83

NicoleRauch opened this issue Aug 18, 2019 · 1 comment

Comments

@NicoleRauch
Copy link

Hello,
I just updated to React 16.9.0, and now I am seeing the following warning:

react-dom.development.js:11495 Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: SkyLightStateless

Could you please have a look into this and make react-skylight compatible with the newest versions of React? Thanks!

@nzayatz14
Copy link

@marcio I submitted a pull request to replace the functions

#84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants