BuildingLayer: Support extrusions in Mapzen Layer #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately the numberformatter of java isn't supported in web apps. Need to include com.google.gwt.i18n.client.numberformat or is there a simpler way? How can I setup the reference for this case? |
Gustl22
force-pushed
the
S3DB
branch
2 times, most recently
from
339ade9 to
b8ec7fe
Compare
+ Tag add "levels" + BuildingLayer: support extrusions with height and levels, string unit in meters + Add some copyrights + Adapt S3DB Layer / rerange code + Support height for Mapzen building_parts + Support of building parts in default theme and mapzen
|
Thanks, will check it! Quick remark: public static float round2(float value) {
return Math.round(value * 100) / 100f;
} |
devemux86
pushed a commit
that referenced
this pull request
Oct 3, 2017
+ Tag add "levels" + BuildingLayer: support extrusions with height and levels, string unit in meters + Support height for Mapzen building_parts + Support of building parts in default theme and mapzen
|
Merged via fa658bd with slight improvements.. Also with some cleanup, as better have light focused pull requests without irrelevant changes mixed together. 🙂 |
|
Yes, I shuffled together some irrelevant stuff. Sorry for that ;D. Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first approach of support for extrusions in other layers than OscimMap4 in VTM. Therefore a unification of tags is necessary and support of S3DB tags in mapsforge maps. I reorganized some code, but only for clarity. There are some hardcoded calculations on height for mapzen layer, because this tag is derived from the area and volume (usually for building_parts). Criticism is welcome ;D