Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer.setEnabled (false) has been ignored. #342

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Layer.setEnabled (false) has been ignored. #342

merged 1 commit into from
Mar 28, 2017

Conversation

Longri
Copy link

@Longri Longri commented Mar 27, 2017

This PR treats the layer.enabled flag.

As an example, you can turn the BuildingLayer on or off in the Playground Project by pressing the 'B' key!

@devemux86
Copy link
Collaborator

Thanks!
Need to think a little the implementation.

For example why the need of a new handler, couldn't we solve its need without it?
Also Layers could need more work, e.g. there are unbind also in set method.

@devemux86
Copy link
Collaborator

Ok I simplified a bit the concept, will do the merge later.

@devemux86 devemux86 added this to the 0.8.0 milestone Mar 28, 2017
@devemux86 devemux86 merged commit 9fff945 into mapsforge:master Mar 28, 2017
devemux86 added a commit that referenced this pull request Mar 28, 2017
@devemux86
Copy link
Collaborator

Thanks!
Merged via 9fff945 and simplified via 8ab2195.

@Longri please see too that all work fine.

@Longri Longri deleted the handle_layer_enable_disable branch March 29, 2017 06:32
@Longri
Copy link
Author

Longri commented Mar 29, 2017

looks good, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants