Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapFileTileSource zoom level API enhancements #219

Closed
devemux86 opened this issue Oct 30, 2016 · 7 comments
Closed

MapFileTileSource zoom level API enhancements #219

devemux86 opened this issue Oct 30, 2016 · 7 comments
Milestone

Comments

@devemux86
Copy link
Collaborator

devemux86 commented Oct 30, 2016

MapFileTileSource has a max zoom level 17 for tiles rendering, which can be limited to users.
We could make that optional and think about increasing default max zoom to 18?

Note: this has nothing to do with map zoom limits, as map view can zoom to our will using that data, e.g. zoom 20 and beyond.

Related zoom conversation in opensciencemap#122.

@devemux86 devemux86 added this to the 0.7.0 milestone Oct 30, 2016
@devemux86 devemux86 changed the title MapFileTileSource zoom level options MapFileTileSource zoom level improvements Oct 30, 2016
@devemux86
Copy link
Collaborator Author

I added parameters for the zoom levels but didn't increase the default max zoom to 18, as then we have artifacts at tile seams (see opensciencemap#122 for details).

@devemux86 devemux86 changed the title MapFileTileSource zoom level improvements MapFileTileSource zoom level API enhancements Nov 12, 2016
@andreynovikov
Copy link

I have read that having separate zoom levels beyond 14 for vector tiles has little sense. What should be done to address these issues is separation of data extraction and rendering. Currently if zoom level is beyond max data source zoom level the rules for max zoom level are applied, but not for current zoom. I propose to make it use the data from max data source zoom level but to apply rendering rules for current zoom level.

@devemux86
Copy link
Collaborator Author

Actually 14 is the last default base zoom level in Mapsforge maps, so what you propose is valid.
Though online vector tiles (.vtm or .mvt) extract data from larger zooms too?

And indeed current VTM data read & render zooms are not independent, so we have #216.
@hjanetzek can confirm that.

BTW theme creators should be allowed to work as before and set min zoom in tag-mapping >14, right?

@andreynovikov
Copy link

Yes, this is what I propose. For instance I have a base map data source (in separate layer) with max zoom level of only 8. It renders nicely on zoom 20 but relevant theme rules are not applied - VTM just scales what was set for zoom level 8.

@andreynovikov
Copy link

I'm currently implementing a new data source for my app. It will be limited with zoom 14. So this issue becomes important to me. I want to address it shortly. Any ideas and recommendations on how to separate data extraction and rendering?

@devemux86
Copy link
Collaborator Author

Do you mean only for Mapsforge map files or generally for all vector map sources?

@andreynovikov
Copy link

For all vector tile sources. But it looks like it's very complicated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants