Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format not handled correctly in image.save #528

Open
springmeyer opened this issue Sep 28, 2015 · 0 comments
Open

Format not handled correctly in image.save #528

springmeyer opened this issue Sep 28, 2015 · 0 comments

Comments

@springmeyer
Copy link
Member

Companion to #527: if a faulty format option is passed the expectation is that the function will throw (rather than just return an error in the callback). But based on how https://github.com/mapnik/node-mapnik/blob/master/src/mapnik_image.cpp#L3361-L3377 works a faulty format option will sneak through into the async machinery. This makes it inconsistent to the sync function in behavior with an invalid format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant