New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused `format` argument in ImageView.save #527

Open

2 tasks

springmeyer opened this issue Sep 28, 2015 · 0 comments

Member

springmeyer commented Sep 28, 2015

The format arg is handled (https://github.com/mapnik/node-mapnik/blob/master/src/mapnik_image_view.cpp#L578-L593) but never passed to mapnik::save_to_file.

TODO:

fix the above bug and start respecting format by passing as third arg to mapnik::save_to_file
review other usage of mapnik::save_to_file in node-mapnik and ensure we have test coverage for when the format is not passed and is incorrect.

The text was updated successfully, but these errors were encountered:

This was referenced Sep 28, 2015

Format not handled correctly in image.save #528

Open

Upgrade to Nan 2.0 #509

Merged

springmeyer pushed a commit that referenced this issue


          improve test coverage for ImageView.save - refs #509 #527 #528

477c259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment