Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in case of empty ring #3833

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

talaj
Copy link
Member

@talaj talaj commented Jan 17, 2018

The polygon_vertex_processor which is responsible for constructing mapnik::geometry::polygon out of vertex stream was crashing when the vertex stream contained only SEG_CLOSE command.

@artemp
Copy link
Member

artemp commented Jan 17, 2018

👍

@artemp artemp merged commit da8b5c4 into mapnik:master Jan 17, 2018
@artemp artemp added the bug label Jan 17, 2018
@artemp artemp added this to the Mapnik 3.1.0 milestone Jan 17, 2018
@artemp artemp assigned artemp and talaj and unassigned artemp Jan 17, 2018
@artemp artemp requested review from artemp and removed request for artemp January 17, 2018 10:07
@codecov
Copy link

codecov bot commented Jan 17, 2018

Codecov Report

Merging #3833 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3833      +/-   ##
==========================================
+ Coverage   68.47%   68.47%   +<.01%     
==========================================
  Files         441      441              
  Lines       23017    23018       +1     
==========================================
+ Hits        15761    15762       +1     
  Misses       7256     7256
Impacted Files Coverage Δ
...clude/mapnik/geometry/polygon_vertex_processor.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab4e1b7...ec53f3d. Read the comment docs.

@artemp artemp modified the milestones: v3.1.0, v3.0.18 Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants