Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or Upgrade android-sdk-versions-plugin to latest version #484

Closed
birkskyum opened this issue Sep 18, 2022 · 5 comments · Fixed by #515
Closed

Remove or Upgrade android-sdk-versions-plugin to latest version #484

birkskyum opened this issue Sep 18, 2022 · 5 comments · Fixed by #515
Labels

Comments

@birkskyum
Copy link
Member

birkskyum commented Sep 18, 2022

The android-sdk-versions-plugin is currently blocking an Upgrade of Grade #483 .

The mapbox/android-sdk-versions-plugin repo isn't publishing the latest changes to maven central, with the latest published version being 1.1.0, and the latest repo version 1.1.3.

The version we need is >= 1.1.1.

We can publish it in our Nexus account and move to it instead.

Work on cloning and publishing it can be found in here: https://github.com/birkskyum/android-sdk-versions-plugin

@birkskyum
Copy link
Member Author

@carlonzo is this something you have experience with and can help with? publishing to maven central i mean?

@carlonzo
Copy link
Collaborator

Sure I could have a look. I guess the authentication is already setup on CI?

Otherwise I had a look last time at removing the plugin, given that I can't find any reference in code to the file generated by the plugin (it's a file containing the version of the MapLibre SDK). Would you consider the option to remove it otherwise, if we prove that the SDK works without it?

@birkskyum
Copy link
Member Author

If it isn't in use I think removing it makes a lot of sense

@birkskyum
Copy link
Member Author

It says on the plugin readme site that

All Mapbox android SDK modules that incorporate the Telemetry SDK and meant to be released as libraries(artifacts) should apply this plugin to facilitate the Telemetry SDK access all Mapbox library versions at run time.

And given that we don't have telemetry at all, maybe that's why it isn't in use

@birkskyum
Copy link
Member Author

I'll be damned, removing it and upgrading gradle seems to work (:

@birkskyum birkskyum changed the title Upgrade android-sdk-versions-plugin to latest version Remove or Upgrade android-sdk-versions-plugin to latest version Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants