Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomGeometrySourceOptions.withClip always enabled? #2262

Open
Helium314 opened this issue Apr 15, 2024 · 1 comment
Open

CustomGeometrySourceOptions.withClip always enabled? #2262

Helium314 opened this issue Apr 15, 2024 · 1 comment
Labels

Comments

@Helium314
Copy link
Contributor

Using a CustomGeometrySource appears to display only geometry for one tile, and does not allow geometry from neighboring tiles to across a tile border. For example the the blue and red lines on the screenshot bekow come from a CustomGeometrySource:

Screenshot_20240414-130815_Street­Complete_Dev

There are 4 tiles in the image, I think it's visible where the tile edges are. You will notice that the blue road in the center has a white section in the bottom left tile. This is because the road is not returned when the source queries features for this tile.

Reading in documentation, I understand it should be possible to get data from outside tile boundaries using withClip.
I would expect that it allows the blue lines to cross tile boundaries, so they are displayed completely. But actually it seems that the withClip value does not change anything, it always looks like in the screenshot.

Is this a bug, or am I misunderstanding what withClip is doing?

MapLibre 11.0.0-pre4
Samsung Galaxy A3, LineageOS 17

@westnordost
Copy link
Collaborator

westnordost commented Apr 15, 2024

In short, the expectation of the issue reporter is that withClip = false would result in that the line marked in orange from the tile marked in green on the below picture would cross into and through the other tiles, as the line has not been clipped.
(And since the line is likely part of the upper left tile too, would be drawn two times - one time as part of the geometry contained in the upper left tile, the other time as part of the geometry in the lower right tile)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants