-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mapbox watermark on the maps with maplibre #643 and replace mapbox resource names #647
Conversation
That was actually @ntadej that said to make the icon configurable. I was just saying in maplibre-gl-js it used show based on a mapbox tilejson parameter. it had been changed at one point to look for a maplibre tilejson parameter, which meant it basically never was shown. I had modified in the js version in maplibre/maplibre-gl-js#786 so it no longer shows based on TileJSON, but instead was a settable map option. The reason was more to repurpose this logo to give maplibre project a bit more visibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transitioning the resourcePrefix from 'mapbox_'
to resourcePrefix from 'maplibre_'
almost deserves it's own PR, but in order to do it stepwise like this, I reckon it can be disabled to let the lint pass while it's ongoing.
@birkskyum Since you said 'almost'... I added |
Great! I'd like an Android changelog entry. Also, it's generally preferred to use rebate rather than merge when synching the branch to master as it simplifies the git history. |
Thanks for the heads-up, I will do that next time. When I squash the commits when I merge later, the git history should be clean in this case right (because the branches haven't diverged)? |
Yes, it'll be clean in the main branch after squashing, so it's only related to the review process |
Closes #643
You can already disable the icon, but
@acalcutt@ntadej had the idea to make it configurable which icon is shown. We should create a ticket out of this.