Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minSDK to 21 and remove mistakenly submitted files adding them t… #630

Merged
merged 8 commits into from
Dec 22, 2022
Merged

Bump minSDK to 21 and remove mistakenly submitted files adding them t… #630

merged 8 commits into from
Dec 22, 2022

Conversation

artakka
Copy link
Collaborator

@artakka artakka commented Dec 21, 2022

…o .gitignore

@artakka artakka mentioned this pull request Dec 21, 2022
Merged
@artakka artakka mentioned this pull request Dec 22, 2022
Closed
@wipfli
Copy link
Contributor

wipfli commented Dec 22, 2022

Sorry for nagging but can you add a link to the pull request in the changelog? See examples in other changelog entries.

wipfli
wipfli approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@wipfli wipfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the changelog link, then this is good from my side. Thanks @artakka

@artakka
Copy link
Collaborator Author

artakka commented Dec 22, 2022

@wipfli No problem. Good to be consistent.

@artakka artakka merged commit eff76f8 into maplibre:main Dec 22, 2022
@artakka artakka deleted the minSDK branch December 27, 2022 00:19
@link2xt link2xt mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wipfli wipfli wipfli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artakka @wipfli