Revert "Revert "Gradle update"" #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 330eb81.
wipfli
commented
Dec 19, 2022
Comment on lines
+67
to
69
| - name: Setup Android SDK for accepting tool licenses | ||
| uses: android-actions/setup-android@v2 | ||
|
|
There was a problem hiding this comment.
Maybe we should update the docker container instead...
wipfli
commented
Dec 19, 2022
Comment on lines
+126
to
+128
| cmakeVersion: 3.10.2 | ||
| ninjaVersion: latest | ||
|
|
There was a problem hiding this comment.
Similar here, we might want to update the docker container instead
wipfli
commented
Dec 19, 2022
Comment on lines
+66
to
+67
| - name: Setup Android SDK for accepting tool licenses | ||
| uses: android-actions/setup-android@v2 |
There was a problem hiding this comment.
We might want to update the docker container instead...
|
I started putting a bit of information together about the android docker build containers at #622 |
birkskyum
approved these changes
Dec 20, 2022
|
Feel free to merge this, @birkskyum. We can update the docker container in a follow-up pull request... |
|
Let us have tasks as they are good changes to make in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #614
We want the gradle update which @artakka prepared, so let's introduce it again...