-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sinon
with nise
#554
Comments
What do you mean exactly? Would you like to change now or should we add it to list #458 ? |
We can do it whenever we want - either when we finish migrating all the tests and then do a sweep to change it, or change it now and make sure that every test that we convert uses the "new way". |
@birkskyum thanks for pushing this forward!! |
Sure! I'm still trying to figure out how we can get the remaining integration tests modernized too and leaved test'em etc. behind for good. |
Motivation
It seems that we are using
sinon
mainly for the fake http server.nise
is this part of sinon exactly and their typings is a bit better than sinon's.I would advise to add
nise
to the jest test migration effort and removesinon
once we are done with the migration.The text was updated successfully, but these errors were encountered: