Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for sqlite3_interrupt. This makes it possible to interrupt a long running query.
I called the function synchronously instead of going through
db->Schedule
because if it was scheduled it wouldn't be possible to interruptexec
. This is because whileexec
is running the work queue is not processed. Also, thesqlite3_interrupt
function doesn't do any I/O or acquire any locks, so it won't block the javascript thread.The downside of calling
sqlite3_interrupt
synchronously means that it has to check whether the database is open, and has to check thatsqlite3_close
is not about to be run by another thread. Basically, ifsqlite3_interrupt
is called on an already closed database, then it could cause memory corruption.To avoid this, I added a
closing
variable that's set right before sending aclose
to a worker thread. Theopen
variable isn't sufficient because it's only set tofalse
aftersqlite3_close
has been called.