Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed: A GitHub Action to package and publish a new version #739

Open
cclauss opened this issue Jun 29, 2024 · 6 comments
Open

Needed: A GitHub Action to package and publish a new version #739

cclauss opened this issue Jun 29, 2024 · 6 comments
Labels
github_actions Pull requests that update GitHub Actions code release-process

Comments

@cclauss
Copy link
Collaborator

cclauss commented Jun 29, 2024

@cclauss cclauss added github_actions Pull requests that update GitHub Actions code release-process labels Jun 29, 2024
@cclauss cclauss pinned this issue Jun 29, 2024
@cclauss cclauss mentioned this issue Jun 29, 2024
@acalcutt
Copy link
Contributor

In maplibre-native workflow we settled on this workflow that checks if the version in package.json is published.
https://github.com/maplibre/maplibre-native/blob/main/.github/workflows/node-release.yml#L9-L34

If it is not published it runs the build
https://github.com/maplibre/maplibre-native/blob/main/.github/workflows/node-release.yml#L38

maybe something like that would work here. Seems like it would be easier because this project doesn't really need to build anything, just run the publish steps.
https://github.com/maplibre/maplibre-native/blob/main/.github/workflows/node-release.yml#L304-L310

@cclauss
Copy link
Collaborator Author

cclauss commented Jun 29, 2024

Cool! Pull requests will be reviewed. Let's see how that approach works.

@cclauss cclauss unpinned this issue Jun 29, 2024
@mapsam
Copy link
Contributor

mapsam commented Jul 1, 2024

I'm in favor of GitHub release for this as well. This may be blocked by using the @mapbox/node-pre-gyp namespace for a bit, since the Mapbox NPM scope is pretty locked down and I'm not sure we'll be able to grant tokens for public repositories like this. Ultimately this is a good argument to move back to the unscoped node-pre-gyp NPM module which does not have the same security restrictions.

Not ideal, but in the short-term I can cut one-off prereleases for @mapbox/node-pre-gyp as needed @cclauss

@cclauss cclauss pinned this issue Jul 2, 2024
@cclauss
Copy link
Collaborator Author

cclauss commented Jul 2, 2024

I understand the complexities. I think we need a pre-release and then a release BEFORE we merge other changes (all the Dependabot changes, etc.). Please proceed with that pre-release when you feel comfortable doing so.

@mapsam
Copy link
Contributor

mapsam commented Jul 3, 2024

Sounds good! Can you give me a commit to prerelease from? Just want to make sure I release what you're expecting. Latest master is 13d4ac7

I'll plan on 1.1.0-dev.1 since Node.js 22 has been added, but if you see this as a breaking change happy to move into v2 v1.0.11...master

@mapsam
Copy link
Contributor

mapsam commented Jul 3, 2024

@mapbox/[email protected] has been published from 13d4ac7.

I need to push package.json version changes to GitHub in order to publish to the @mapbox/ namespace, so technically the version is published from 996b31b.

I'll use https://github.com/mapbox/node-pre-gyp/tree/mapsam/v1.1.0-pre and keep it in sync with master as you need more dev releases and until the GitHub Actions work is set up.

@cclauss let me know if you'd prefer a separate ticket to request/discuss releases, just to keep this issue focused on the GitHub Action work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code release-process
Projects
None yet
Development

No branches or pull requests

3 participants