Electron runtime detection #188

es128 · 2015-11-13T06:58:26Z

From: fsevents/fsevents#93 (comment) (//cc @stdavis)

node-pre-gyp ERR! install error 
node-pre-gyp ERR! stack Error: Unsupported target version: 0.34.0
node-pre-gyp ERR! stack     at get_runtime_abi (/Users/stdavis/Documents/Projects/atom-amdbutler/node_modules/chokidar/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/versioning.js:156:23)
node-pre-gyp ERR! stack     at Object.module.exports.evaluate (/Users/stdavis/Documents/Projects/atom-amdbutler/node_modules/chokidar/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/versioning.js:265:19)
node-pre-gyp ERR! stack     at install (/Users/stdavis/Documents/Projects/atom-amdbutler/node_modules/chokidar/node_modules/fsevents/node_modules/node-pre-gyp/lib/install.js:138:31)
node-pre-gyp ERR! stack     at Object.self.commands.(anonymous function) [as install] (/Users/stdavis/Documents/Projects/atom-amdbutler/node_modules/chokidar/node_modules/fsevents/node_modules/node-pre-gyp/lib/node-pre-gyp.js:48:37)
node-pre-gyp ERR! stack     at run (/Users/stdavis/Documents/Projects/atom-amdbutler/node_modules/chokidar/node_modules/fsevents/node_modules/node-pre-gyp/bin/node-pre-gyp:79:30)
node-pre-gyp ERR! stack     at Object.&lt;anonymous&gt; (/Users/stdavis/Documents/Projects/atom-amdbutler/node_modules/chokidar/node_modules/fsevents/node_modules/node-pre-gyp/bin/node-pre-gyp:131:1)
node-pre-gyp ERR! stack     at Module._compile (module.js:456:26)
node-pre-gyp ERR! stack     at Object.Module._extensions..js (module.js:474:10)
node-pre-gyp ERR! stack     at Module.load (module.js:356:32)
node-pre-gyp ERR! stack     at Function.Module._load (module.js:312:12)
node-pre-gyp ERR! System Darwin 15.0.0
node-pre-gyp ERR! command "node" "/Users/stdavis/Documents/Projects/atom-amdbutler/node_modules/chokidar/node_modules/fsevents/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/stdavis/Documents/Projects/atom-amdbutler/node_modules/chokidar/node_modules/fsevents
node-pre-gyp ERR! node -v v0.10.40
node-pre-gyp ERR! node-pre-gyp -v v0.6.15
node-pre-gyp ERR! not ok 

npm ERR! Darwin 15.0.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/stdavis/.atom/.apm/.apmrc" "--userconfig" "/Users/stdavis/.atom/.apmrc" "rebuild" "--target=0.34.0" "--arch=x64"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! code ELIFECYCLE
npm ERR! [email protected] install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! This is most likely a problem with the fsevents package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get their info via:
npm ERR!     npm owner ls fsevents
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/stdavis/Documents/Projects/atom-amdbutler/npm-debug.log

node-pre-gyp does not appear to try to auto-detect electron:

node-pre-gyp/lib/util/versioning.js

Line 252 in 2e5590a

    
           var runtime = options.runtime || (process.versions['node-webkit'] ? 'node-webkit' : 'node');

When the install command is baked in to a package, how would an end-user be able apply the equivalent of --runtime=electron in order to prevent their npm install from barfing?

The text was updated successfully, but these errors were encountered:

es128 · 2015-11-13T07:14:19Z

Appears there are two PRs open to address this: #177 & #187

stdavis · 2015-11-13T14:25:13Z

Thanks, @es128!

stdavis · 2015-11-24T14:12:02Z

Any updates on this issue? I can see that the two PR's are still open. Anything that I can do to help get one of them accepted?

hedefalk · 2016-03-31T11:44:38Z

Hi! I'm really struggling with using chokidar -> fsevents -> node-pre-gyp in an Atom plugin.

apm rebuild still fails for me. Repro is as simple as downloading Atom and running apm rebuild on fsevents.

I reported here:
atom/apm#531

but maybe here is a better place to ask? Seems the open issues just lie around…

springmeyer · 2016-03-31T17:53:53Z

We've fix that is now in the released v0.6.26 (#187)

hedefalk · 2016-03-31T20:28:47Z

@springmeyer I guess you mean 0.6.25?

I got hopeful here when I saw this released and the following release of fsevents using this (thanks @es128 ). But fsevents still fails with node-pre-gyp with 0.6.25 using apm rebuild:

~/d/p/fs-events-apm-rebuild ❯❯❯ rm -rf node_modules
~/d/p/fs-events-apm-rebuild ❯❯❯ npm install

> [email protected] install /Users/viktor/dev/projects/fs-events-apm-rebuild/node_modules/fsevents
> node-pre-gyp install --fallback-to-build

[fsevents] Success: "/Users/viktor/dev/projects/fs-events-apm-rebuild/node_modules/fsevents/lib/binding/Release/node-v46-darwin-x64/fse.node" is installed via remote
[email protected] /Users/viktor/dev/projects/fs-events-apm-rebuild
└─┬ [email protected]
  ├── [email protected]
  └─┬ [email protected]
  …


~/d/p/fs-events-apm-rebuild ❯❯❯ apm rebuild
Rebuilding modules ✗
node-pre-gyp ERR! install error
node-pre-gyp ERR! stack Error: Unsupported target version: 0.34.5
node-pre-gyp ERR! stack     at get_runtime_abi (/Users/viktor/dev/projects/fs-events-apm-rebuild/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/versioning.js:156:23)
node-pre-gyp ERR! stack     at Object.module.exports.evaluate (/Users/viktor/dev/projects/fs-events-apm-rebuild/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/versioning.js:277:19)
node-pre-gyp ERR! stack     at install (/Users/viktor/dev/projects/fs-events-apm-rebuild/node_modules/fsevents/node_modules/node-pre-gyp/lib/install.js:138:31)
node-pre-gyp ERR! stack     at Object.self.commands.(anonymous function) [as install] (/Users/viktor/dev/projects/fs-events-apm-rebuild/node_modules/fsevents/node_modules/node-pre-gyp/lib/node-pre-gyp.js:48:37)
node-pre-gyp ERR! stack     at run (/Users/viktor/dev/projects/fs-events-apm-rebuild/node_modules/fsevents/node_modules/node-pre-gyp/bin/node-pre-gyp:79:30)
node-pre-gyp ERR! stack     at Object.<anonymous> (/Users/viktor/dev/projects/fs-events-apm-rebuild/node_modules/fsevents/node_modules/node-pre-gyp/bin/node-pre-gyp:131:1)
node-pre-gyp ERR! stack     at Module._compile (module.js:456:26)
node-pre-gyp ERR! stack     at Object.Module._extensions..js (module.js:474:10)
node-pre-gyp ERR! stack     at Module.load (module.js:356:32)
node-pre-gyp ERR! stack     at Function.Module._load (module.js:312:12)
node-pre-gyp ERR! System Darwin 15.3.0
node-pre-gyp ERR! command "node" "/Users/viktor/dev/projects/fs-events-apm-rebuild/node_modules/fsevents/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/viktor/dev/projects/fs-events-apm-rebuild/node_modules/fsevents
node-pre-gyp ERR! node -v v0.10.40
node-pre-gyp ERR! node-pre-gyp -v v0.6.25
node-pre-gyp ERR! not ok

npm ERR! Darwin 15.3.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/viktor/.atom/.apm/.apmrc" "--userconfig" "/Users/viktor/.atom/.apmrc" "rebuild" "--target=0.34.5" "--arch=x64"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! code ELIFECYCLE
npm ERR! [email protected] install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! This is most likely a problem with the fsevents package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get their info via:
npm ERR!     npm owner ls fsevents
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/viktor/dev/projects/fs-events-apm-rebuild/npm-debug.log

stdavis mentioned this issue Nov 13, 2015

Package won't build at Atom 1.2.0 agrc/atom-amdbutler#13

Closed

viddo mentioned this issue Mar 31, 2016

Upgrade or change chokidar dependency? viddo/atom-textual-velocity#9

Closed

hedefalk mentioned this issue Mar 31, 2016

Reporting "incompatible native module" on non-existing transitive devDependency. atom/atom#11331

Closed

springmeyer closed this as completed Mar 31, 2016

hedefalk mentioned this issue Mar 31, 2016

fixes #531 atom/apm#536

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Electron runtime detection #188

Electron runtime detection #188

es128 commented Nov 13, 2015

es128 commented Nov 13, 2015

stdavis commented Nov 13, 2015

stdavis commented Nov 24, 2015

hedefalk commented Mar 31, 2016

springmeyer commented Mar 31, 2016

hedefalk commented Mar 31, 2016

Electron runtime detection #188

Electron runtime detection #188

Comments

es128 commented Nov 13, 2015

es128 commented Nov 13, 2015

stdavis commented Nov 13, 2015

stdavis commented Nov 24, 2015

hedefalk commented Mar 31, 2016

springmeyer commented Mar 31, 2016

hedefalk commented Mar 31, 2016