Cancel download should remove currently downloaded map #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ph0tonic
force-pushed
the
p0-offline-plugin-cancel-download
branch
from
b678813 to
e75a8a0
Compare
|
I have finally been able to test it and it's working as expected. The problem happened only when the UUID of an @LukasPaczos and @tobrun this PR is now definitely ready for a review 👍 |
tobrun
approved these changes
Jul 30, 2020
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a look at the code of the offline plugin and find out what might cause the cancel download not to delete the currently downloading map.
This is a PR to fixes #189
Note : I have not been able to actually test that this fix the issue as there is no cancel button in the demo app but in any case what I changed is pretty straightforward and I strongly believe that the previous versions might prevent the map to be deleted.
Any comment and review is most welcome @tobrun, @LukasPaczos and @langsmith