Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor monitorStepProgress #278

Closed
1ec5 opened this issue Jun 13, 2017 · 5 comments
Closed

Refactor monitorStepProgress #278

1ec5 opened this issue Jun 13, 2017 · 5 comments
Labels
archived Archived issue.

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jun 13, 2017

monitorStepProgress(_:) has grown unwieldy and would frustrate any attempt to unit test Core Navigation. We should break it up into logical units based on specific decisions being made.

/cc @bsudekum @frederoni
@1ec5
Copy link
Contributor Author

1ec5 commented Jun 14, 2017

We may want to hew to mapbox/mapbox-navigation-android#30 when refactoring this method.

@1ec5
Copy link
Contributor Author

1ec5 commented Jun 19, 2017

This will happen as part of #282.

@1ec5 1ec5 mentioned this issue Jun 23, 2017
Closed
@ericrwolfe
Copy link
Contributor

This didn't happen as part of #282.

@stale
Copy link

stale bot commented Jul 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the archived Archived issue. label Jul 29, 2020
@stale
Copy link

stale bot commented Aug 9, 2020

Stale.

@stale stale bot closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
archived Archived issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericrwolfe @1ec5