fixed endnavigation issue #69
Conversation
|
|
||
| @Override | ||
| public void onProgressChange(Location location, RouteProgress routeProgress) { | ||
|
|
|
|
||
| // If the user arrives at the final destination, end the navigation session. | ||
| if (routeProgress.getAlertUserLevel() == NavigationConstants.ARRIVE_ALERT_LEVEL) { | ||
| System.out.println("working"); |
| @@ -438,7 +455,7 @@ public void onServiceConnected(ComponentName componentName, IBinder service) { | |||
| if (alertLevelChangeListeners != null) { | |||
| navigationService.setAlertLevelChangeListeners(alertLevelChangeListeners); | |||
| } | |||
|
|
|||
| progressChangeListeners.add(MapboxNavigation.this); | |||
There was a problem hiding this comment.
This doesn't seem right, the object is implementing a listener that is keeping track of. Also, the next line is always true because there always is at least one ProgressChangeListener. Could you elaborate why is this needed?
There was a problem hiding this comment.
The if null checks were leftovers from before when we didn't add the listeners to a list, I've removed them since the list are always set in the constructor. The MapboxNavigation objects listening in to get notified when the user arrives at the destination. When this occurs, the sessions, automatically ended. Otherwise, the service would continue running in the background even though the navigation sessions over.
I'm not really happy with the current setup with everything being passed inside the onConnected callback since this is only called once when the service is first created, but I'll need more time to refactor.
| @@ -403,7 +420,7 @@ public float getUserOriginBearing() { | |||
| * @since 0.3.0 | |||
| */ | |||
| public MapboxNavigationOptions getMapboxNavigationOptions() { | |||
| return options; | |||
| return isServiceAvailable() ? navigationService.getMapboxNavigationOptions() : options; | |||
There was a problem hiding this comment.
Why do we have two different copies of options?
Closes #68
Fixes issue with navigationSession using old reference of service even after the service is destroyed.