Update Strings with Transifex Translations #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericrwolfe we currently don't have > 80% of these Strings translated. Do I lower the threshold and then wait / in another PR update once the Strings have been translated by the community? |
langsmith
approved these changes
Jan 19, 2018
danesfeder
force-pushed
the
dan-transifex
branch
from
ae62af9 to
befa025
Compare
danesfeder
force-pushed
the
dan-transifex
branch
from
befa025 to
e87e23f
Compare
danesfeder
force-pushed
the
dan-transifex
branch
from
a739d6c to
f151744
Compare
TranThuong
pushed a commit
to TranThuong/mapbox-navigation-android
that referenced
this pull request
Jan 26, 2018
* master: Update Strings with Transifex Translations (mapbox#657) Added embedded navigation example (mapbox#654) Release 0.9.0 (mapbox#663) Update README.md for 0.9.0 (mapbox#664) Add Maneuver type exit rotary constant (mapbox#653) Update Maps and Services dependencies (mapbox#661) Add FasterRouteDetector to check for quicker routes while navigating (mapbox#638) Directions API Banner instructions (mapbox#582) NavigationTelemetry update cue for changing configurations (mapbox#648) Moved WaypointNavigationActivity from the SDK to the test app (mapbox#652) Exposes the MapboxMap in NavigationView with a getter method (mapbox#642) Add language to NavigationViewOptions with default from RouteOptions (mapbox#635) # Conflicts: # libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationEngine.java # libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationService.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates transifex config to push / pull from both
libandroid-navigationandlibandroid-navigation-ui(thanks @langsmith)Pulls in latest translations and creates new resource packages for each string XML with a different language.
cc @ericrwolfe