fixes a regression that appended wrong distance traveled value to RouteProgress
#4749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-progress-regression
branch
from
0d95a1c to
cd0056d
Compare
Guardiola31337
approved these changes
Aug 24, 2021
libnavigation-core/src/main/java/com/mapbox/navigation/core/navigator/NavigatorMapper.kt
Outdated
Show resolved
Hide resolved
LukasPaczos
force-pushed
the
lp-progress-regression
branch
from
cd0056d to
8088d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression from #4509 where
RouteProgress#distanceTraveledwas reported incorrectly for multi-leg routes.At some point in time, we unnecessarily commented out a lot of tests that probably would've caught the issue. This PR reintroduces and extends these tests while leaving only the actually blocked cases ignored.
Changelog