Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_name is overwrite by libandroid-navigation #883

Closed
ben-j69 opened this issue Apr 25, 2018 · 3 comments
Closed

app_name is overwrite by libandroid-navigation #883

ben-j69 opened this issue Apr 25, 2018 · 3 comments

Comments

@ben-j69
Copy link

ben-j69 commented Apr 25, 2018

Hello,

the values in differents folders like "values-fr" are taking priority on the values of my app, the result is that in french my android app is now called "SDK de navigation Mapbox pour Android" because my app_name value is replaced by the on in libandroid-navigation

**Android API:16
**Mapbox Navigation SDK version:0.12.0

Steps to trigger behavior

1.Integrate mapbox navigation
2.Build the project
3.Start the app

Expected behavior

My app should have its own name from app_name

Actual behavior

app_name from libandroid-navigation is taking priority

@danesfeder
Copy link
Contributor

Hey @ben-j69, yeah it looks like we are storing our test application label String app_name in the core library which is incorrect.

We can adjust this on our side - but while we work on this, would a simple fix on your end be changing the name of the String resource? That way there is no conflict. From app_name to your_app_name or something like that.

@danesfeder
Copy link
Contributor

FWIW, I think this override attribute may fix your problem as well:

<resources xmlns:tools="http://schemas.android.com/tools">
    <string name="app_name" tools:override="true">Your Test App Name</string>
</resources>

@eriknyk
Copy link

eriknyk commented Oct 1, 2018

same problem is happening on plugin-locationlayer also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants