Android: Incorrect Direction Images

[Danny-James]

Being In The UK we drive on the left side of the road, i approached a rounder-bout well testing the Navigation yesterday, the Instructions told me to At the rounder-bout take the second exit

Below is the image that was presented to me - this is showing driving the wrong way around the rounder-bout.

[cammace]

Hey @Danny-James, thanks for reporting, that doesn't look like a roundabout which is most likely an issue with our data rather than an issue with the navigation client. Could you report this upstream using this tool so we can get the proper eyes on it and get it fixed?

[Danny-James]

@cammace the navigation image isn't a rounder-bout as i hadn't approached the rounder-bout, their was actually a rounderbout around the right bend shown above, what im saying is we don't drive on the right side of the road - as you can see the instructions is for in 1.2miles

[Danny-James]

@cammace this still seems to be an issue, in the UK we drive on the left side of the road, the images are showing as if we drive on the right hand side of the road see the image below this is showing for take the third exit.

The image actually looks like take the first exit if driving on the right side of the road.

See 2nd Instuction in Screenshot Below.

[cammace]

OSRM supports different side of the road driving with the left_hand_driving boolean (set to true if driving on the lefthand side). This isn't yet supported by the directions API though which means we can't fix this issue yet. Since this is something that needs to be worked out in the directions API before resolving here, we will keep tracking progress there.

[Danny-James]

@cammace no problem thanks for looking at this issue 👍

[mdakram]

Hi @cammace any timeline on this?

[danesfeder]

@Danny-James @mdakram the solution here would be flipping all maneuver images if the driving side is on the left side correct?

[Danny-James]

@danesfeder is their an option for this if we are using the NavigationLauncher ?

[mdakram]

@danesfeder not exactly as turn right in case of right hand or left hand driving will remain same. Issue i found is with u-Turn and roundabout. @Danny-James you can share your experience.

[danesfeder]

@mdakram uturns should be fixed with #908 and roundabouts now consider the actual angle at which you exit the roundabout #854

[danesfeder]

@Danny-James the ManeuverView doesn't consider the driving side currently (we should do this automatically, no need for options imo)

[Danny-James]

@danesfeder Thank You.

[Danny-James]

@danesfeder I seem to still be getting issue with the Maneuver Images, take a look at the two below images, they don't match and the notification image is showing as driving on the right side of the road.

[Danny-James]

@danesfeder the same rounderbout and same route has given be a different image see below;

The below image, Newport road was to go straight over the rounderbout (Take the second exit), im refering to the upcoming instruction in this image the arrow is pointing back on the rounderbout.

[1ec5]

The screenshots above appear to be 180° off, not flipped. The Directions API documentation states that the roundabout degrees in banner instruction objects are measured head-on, not from the driver’s perspective:

The degrees at which you will be exiting a roundabout, assuming 180 indicates going straight through the roundabout.

[1ec5]

Also tracking this issue for iOS in mapbox/mapbox-navigation-ios#1812.

[andrewharvey]

👍

@mdakram uturns should be fixed with #908 and roundabouts now consider the actual angle at which you exit the roundabout #854

This is still an issue as of 0.33.2, for both uturns and roundabouts.

@Danny-James @mdakram the solution here would be flipping all maneuver images if the driving side is on the left side correct?

Not quite. The left hand side driving icon for turn right at the roundabout would be the turn left at the roundabout's right hand side driving icon, but mirrored on the vertical axis.

Would it be simpler to just embed separate icons or build in this flipping logic?

Happy to try to help, but I wouldn't know where to start.

[Danny-James]

@danesfeder I'm now using the latest stable version of NavigationUI and this issue is still present; The images below I seem to be getting problems with Left Turns showing a Right Turn manoeuvre image

I've just taken a 1 hour journey and every Left Turn was a Right Turn image I also came across one issue with a Traffic Circle. The manoeuvre image was showing the driving line on the wrong side of the road for UK Driving.

Images

[dh06IRL]

Have noted similar issue with backwards instruction images on occasion. Using InstructionView library version 0.41.0

[1ec5]

The issue is that the maneuver view is horizontally flipped for left-hand driving, regardless of the maneuver type:

mapbox-navigation-android/libandroid-navigation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/instruction/maneuver/ManeuverView.java

Lines 237 to 240 in 5036133

	if (drivingSide.equals(STEP_MANEUVER_MODIFIER_RIGHT)) {
	boolean flip = SHOULD_FLIP_MODIFIERS.contains(maneuverModifier);
	setScaleX(flip ? -1 : 1);
	}

On iOS, we flip based on the driving side for roundabout, rotary, roundaboutTurn because the degrees field is specific to those maneuver types only. Left turns are also flipped because the image assets are for right turns; uturn is a special case based on the driving side.

/ref #1946

[1ec5]

Continued in #2191.