Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore locationEngine state to what user had before nav session #38

Closed
cammace opened this issue May 13, 2017 · 2 comments
Closed

Restore locationEngine state to what user had before nav session #38

cammace opened this issue May 13, 2017 · 2 comments

Comments

@cammace
Copy link
Contributor

cammace commented May 13, 2017

When a navigation session begins, we take the instance of the locationEngine passed in and force the updating to happen more frequently. After a nav session, the locationEngine is automatically set to a lower battery consumption settings but this isn't necessarily what the developer had before they started navigating. Perhaps this is an API we should include in locationEngine, thoughts @zugaldia?

@zugaldia
Copy link
Member

How would the new API look like?

@danesfeder
Copy link
Contributor

Given the new LocationEngine APIs added in #1615, I think this ticket is no longer relevant. The state of the LocationEngine is now determined by the LocationEngineRequest.

When navigation ends, we stop requesting updates and the developer would then have the ability to re-request in their code with a new LocationEngineRequest with the state (frequency, priority, etc.) they desire.

Closing here as non-actionable, but feel free to post further thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants