Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TurfMisc.nearestPointOnLine() should use kilometers as default unit for dist #1054

Closed
gwimmel opened this issue Jun 19, 2019 · 0 comments · Fixed by #1058
Closed

TurfMisc.nearestPointOnLine() should use kilometers as default unit for dist #1054

gwimmel opened this issue Jun 19, 2019 · 0 comments · Fixed by #1058
Labels
Turf

Comments

@gwimmel
Copy link
Contributor

gwimmel commented Jun 19, 2019 •
edited
Loading

Expected Behavior

TurfMisc.nearestPointOnLine() should use kilometers as default unit for dist, as documented in http://turfjs.org/docs/#nearestPointOnLine .

An additional version of TurfMisc.nearestPointOnLine() where the distance unit can be specified could be useful.

Current Behavior

TurfMisc.nearestPointOnLine() uses miles as unit for dist
(see e.g. TurfMisc.java#L237 ).

Possible Implementation

If this is a valid issue, maybe I can try and produce a pull request.
@gwimmel gwimmel changed the title nearestpointonline miles TurfMisc.nearestPointoOnLine() should use kilometers as default unit for dists Jun 19, 2019
@gwimmel gwimmel changed the title TurfMisc.nearestPointoOnLine() should use kilometers as default unit for dists TurfMisc.nearestPointoOnLine() should use kilometers as default unit for dist Jun 19, 2019
@gwimmel gwimmel changed the title TurfMisc.nearestPointoOnLine() should use kilometers as default unit for dist TurfMisc.nearestPointOnLine() should use kilometers as default unit for dist Jun 19, 2019
@tobrun tobrun added the Turf label Jun 24, 2019
@langsmith langsmith mentioned this issue Jun 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Turf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added new nearestPointOnLine default and custom distance unit mapbox/mapbox-java
2 participants
@tobrun @gwimmel