Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources.jar artifacts empty on Maven Central #1053

Closed
gwimmel opened this issue Jun 19, 2019 · 9 comments · Fixed by #1064
Closed

sources.jar artifacts empty on Maven Central #1053

gwimmel opened this issue Jun 19, 2019 · 9 comments · Fixed by #1064

Comments

@gwimmel
Copy link
Contributor

gwimmel commented Jun 19, 2019

Expected Behavior

sources.jar on Maven Central (current version: https://search.maven.org/remotecontent?filepath=com/mapbox/mapboxsdk/mapbox-sdk-turf/4.8.0/mapbox-sdk-turf-4.8.0-sources.jar ) contains mapbox-sdk-turf sources.

Current Behavior

The above file seems to contain only empty folders. Therefore one cannot easily navigate to the mapbox-sdk-turf sources in one's IDE.

Possible Solution

If the current behaviour is not intentional, modify the release process for mapbox-sdk-turf such that a valid sources.jar file is generated and uploaded to Maven Central.

Steps to Reproduce

Download the sources.jar - file linked above and view the contents.

@tobrun
Copy link
Member

tobrun commented Jun 25, 2019

thank you for the report @gwimmel, confirmed that no java files are included.

@LukasPaczos
Copy link
Contributor

This is also the case for all artifacts, not only turf.

@gwimmel
Copy link
Contributor Author

gwimmel commented Jun 25, 2019

I guess this is due to be2f75c#diff-c197962302397baf3a4cc36463dce5ea. The "**/*.java" - exclusion probably also applies to the sources jars, which it shouldn't.

@gwimmel
Copy link
Contributor Author

gwimmel commented Jul 5, 2019

The pull request seems to be stale - should I open a new one with my suggestion?

@tobrun
Copy link
Member

tobrun commented Jul 5, 2019

@gwimmel I was trying out your proposed solution with a snapshot build but failed to get a build working (see here for context). Feel free to create a new pull request! You deserve the contributions on this one ;)

@gwimmel
Copy link
Contributor Author

gwimmel commented Jul 5, 2019

Strange - you mean the deployment to jfrog does not work when my proposed solution is applied, but does work otherwise? The problem you cited seems unrelated to me. The sources.jar-Files are also generated/deployed in the current version, the only thing my fix should change is their content.

@tobrun
Copy link
Member

tobrun commented Jul 5, 2019

it doesn't work otherwise either :) I believe your proposed solution will work though I would have loved to verify it with a snapshot build which isn't possible atm 🐼

@gwimmel
Copy link
Contributor Author

gwimmel commented Jul 5, 2019

Here's my pull request. Cannot test it very well either, as in the current build on master the sources.jar-Files seem not to be generated at all (when I execute "gradle assemble"). This definitely worked before the last commit on build.gradle.

@gwimmel gwimmel changed the title mapbox-turf sources.jar empty on Maven Central sources.jar artifacts empty on Maven Central Jul 5, 2019
@langsmith
Copy link

Now that Java SDK SNAPSHOTs are working and available, you two should be able to keep investigating if you'd like. I'll try to swing back 'round to #1064 myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants