Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Speed up GeoJSON conversion in GeoJsonSource #8483

Closed
ivovandongen opened this issue Mar 21, 2017 · 2 comments
Closed

Speed up GeoJSON conversion in GeoJsonSource #8483

ivovandongen opened this issue Mar 21, 2017 · 2 comments
Assignees
@ivovandongen
Labels
Android Mapbox Maps SDK for Android performance Speed, stability, CPU usage, memory usage, or power usage

Comments

@ivovandongen
Copy link
Contributor

Currently, when setting data as a FeatureCollection on a GeoJsonSource, the data is serialised to a string, transferred over JNI to the c++ peer object where it is deserialised with rapidJSON. This comes at a high performance penalty.

Instead we should convert straight from the MAS GeoJson to mapbox::geojson::geojson.
@ivovandongen ivovandongen added Android Mapbox Maps SDK for Android performance Speed, stability, CPU usage, memory usage, or power usage labels Mar 21, 2017
@ivovandongen ivovandongen self-assigned this Mar 21, 2017
@jfirebaugh
Copy link
Contributor

Related: #5623.

@ivovandongen ivovandongen mentioned this issue Mar 22, 2017
Merged
@nitrag
Copy link
Contributor

nitrag commented Mar 22, 2017

Also noticed slow performance compared to iOS. Following.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ivovandongen ivovandongen

Labels
Android Mapbox Maps SDK for Android performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ivovandongen @jfirebaugh @nitrag