Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

simplify point shader #69

Closed
ansis opened this issue Feb 18, 2014 · 4 comments
Closed

simplify point shader #69

ansis opened this issue Feb 18, 2014 · 4 comments
Labels
performance Speed, stability, CPU usage, memory usage, or power usage

Comments

@ansis
Copy link
Contributor

ansis commented Feb 18, 2014

We're currently calculating whether the fragment is within the bounds of the actual icon so that we don't draw parts of the sprite outside of the icon. Maybe we should just pad icons more in the sprite.

https://github.com/mapbox/llmr/blob/master/shaders/point.fragment.glsl#L15-L16

@incanus
Copy link
Contributor

incanus commented Feb 18, 2014

Is a sprite the ultimate destination for this imagery? It's more efficient for texture loading, but I can see a future where arbitrary icons are used, too, so maybe this is premature optimization?

@kkaefer
Copy link
Member

kkaefer commented Feb 19, 2014

@incanus in any case, we're going to use a sprite. Whether it'll be a pre-baked one like now or one that we create on-the-fly (like we do already for glyph images) using some texture atlas system.

@incanus
Copy link
Contributor

incanus commented Feb 19, 2014

👍

@ansis
Copy link
Contributor Author

ansis commented Feb 3, 2015

not relevant anymore

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

No branches or pull requests

3 participants