Core tests not running on iOS on CI

[1ec5]

Along with removing the macOS SDK unit tests (#5991), #5359 also removed the core tests from the iOS test rule. On CI, we’re still installing ios-sim but not using it anywhere. We should be running the core tests on iOS, one of the officially supported platforms.

/cc @jfirebaugh @kkaefer

[1ec5]

This is apparently blocked by ios-control/ios-sim#196.

[boundsj]

Unfortunately our ios-sim does not appear to work with Xcode 8. I'm getting the error: Failed to find class DTiPhoneSimulatorSystemRoot at runtime. I'm going to take this off the 3.4.0 milestone and we can come back to it when there is more time and/or something moves in one of the ios-sim projects (i.e. ios-control/ios-sim#196)

[boundsj]

Additional context for when we pick this up again:

A previous version of the Makefile used to run ios-sim launch $(IOS_OUTPUT_PATH)/Build/Products/$(BUILDTYPE)-iphonesimulator/ios-test.app --verbose --devicetypeid 'com.apple.CoreSimulator.SimDeviceType.iPhone-6,9.3' which corresponds to mbgl-test. This issue is to add back a rule to run that app in the Makefile and also as a step in the ios bitrise configuration.

[jfirebaugh]

Supposedly it's possible to accomplish what we do with ios-sim via xcrun simctl commands, but the thing is not documented in any meaningful way, and neither @1ec5 nor I could figure out the right incantations.

[jfirebaugh]

For posterity, some back-and-forth on radar issues I filed about simctl:

[jfirebaugh]

They're not being run on macOS either, which is why we didn't catch #6579 (comment).

[jfirebaugh]

Restored to macOS in 388fa9c.

[friedbunny]

ios-sim was vestigial since #5359 and is being removed in #10070.

[1ec5]

Supposedly it's possible to accomplish what we do with ios-sim via xcrun simctl commands, but the thing is not documented in any meaningful way, and neither @1ec5 nor I could figure out the right incantations.

This command sends the application’s stdout to the console, but the return value is always 0 as long as the application successfully launches, even if the exit code is nonzero:

xcrun simctl install booted /path/to/mapbox-gl-native/build/ios/Debug-iphonesimulator/core-test.app
xcrun simctl launch --console booted 'com.mapbox.core-test'

[1ec5]

I suppose we can pipe stdout to another command that checks for signs of failure, similar to how xctool and xcpretty work.

[stale]

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.