Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Use strip on the final libraries only so we can use ndk-stack again #6221

Closed
ivovandongen opened this issue Aug 31, 2016 · 1 comment
Closed

Use strip on the final libraries only so we can use ndk-stack again #6221

ivovandongen opened this issue Aug 31, 2016 · 1 comment
Labels
Android Mapbox Maps SDK for Android build
Milestone
android-v4.2.0

Comments

@ivovandongen
Copy link
Contributor

When changing the build to CMake I added stripping in the wrong place (here). This results in all the object files being stripped which prevents us in using ndk-stack to diagnose crashes easily.

Ideally we'll only strip the resulting libraries in the copy target. We can get the strip command from mason with:
echo "set(STRIP_COMMAND \"which $(mason env STRIP)\")" (thanks @kkaefer)
@ivovandongen ivovandongen added build Android Mapbox Maps SDK for Android labels Aug 31, 2016
@ivovandongen
Copy link
Contributor Author

For reference: ndk-stack -sym build/android-arm-v7/Debug/ -dump crash.txt (or something similar).

@ivovandongen ivovandongen mentioned this issue Aug 31, 2016
Merged
@ivovandongen ivovandongen added this to the android-v4.2.0 milestone Aug 31, 2016
@jfirebaugh jfirebaugh mentioned this issue Aug 31, 2016
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android build
Projects
None yet
Milestone
android-v4.2.0
Development

No branches or pull requests
1 participant
@ivovandongen