Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Feature querying should return existing annotations #6178

Closed
1ec5 opened this issue Aug 26, 2016 · 7 comments
Closed

Feature querying should return existing annotations #6178

1ec5 opened this issue Aug 26, 2016 · 7 comments
Labels
annotations Annotations on iOS and macOS or markers on Android archived Archived because of inactivity bug gl-ios iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 26, 2016

When the feature querying API detects a feature in an annotation layer, it should somehow return the MGLAnnotation object that the feature represents – that is, the same MGLAnnotation object that was added to the map to place the feature on the map.

/cc @boundsj

@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS annotations Annotations on iOS and macOS or markers on Android labels Aug 26, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Feb 13, 2017

In particular, the returned feature must not be tiled. Otherwise, the developer will immediately run into a roadblock: #6538.

@friedbunny
Copy link
Contributor

This also includes annotations that happened to conform to MGLFeature — the additional identifier and attributes properties will not be persisted if such an object is added as an annotation.

To make full use of MGLFeature-conforming annotations, instead add them to the map using the runtime styling API.

@1ec5
Copy link
Contributor Author

1ec5 commented Jul 19, 2017

This also includes annotations that happened to conform to MGLFeature — the additional identifier and attributes properties will not be persisted if such an object is added as an annotation.

This will become apparent to the developer at compile time once we fix #7454.

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Dec 1, 2018
@1ec5
Copy link
Contributor Author

1ec5 commented Mar 8, 2019

Still needed as a prerequisite for #6181.

@1ec5 1ec5 reopened this Mar 8, 2019
@stale stale bot removed the archived Archived because of inactivity label Mar 8, 2019
@stale stale bot added the archived Archived because of inactivity label Sep 4, 2019
@stale
Copy link

stale bot commented Sep 4, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Sep 4, 2019
@julianrex julianrex reopened this Sep 5, 2019
@stale stale bot removed the archived Archived because of inactivity label Sep 5, 2019
@stale stale bot added the archived Archived because of inactivity label May 20, 2020
@stale
Copy link

stale bot commented May 22, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android archived Archived because of inactivity bug gl-ios iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

4 participants