Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MGLGeoJSONSource.geoJSONData should be writeable #6159

Closed
1ec5 opened this issue Aug 25, 2016 · 5 comments
Closed

MGLGeoJSONSource.geoJSONData should be writeable #6159

1ec5 opened this issue Aug 25, 2016 · 5 comments
Assignees
@boundsj
Labels
GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Milestone
ios-v3.4.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 25, 2016 •
edited
Loading

MGLGeoJSONSource’s geoJSONData property should be read-write. (Should the URL property be read-write too?)

This is the iOS/macOS counterpart to #5906 on Android.

/cc @frederoni @ivovandongen
@1ec5 1ec5 added GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling labels Aug 25, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 25, 2016
This was referenced Aug 25, 2016
Closed
Open
@ivovandongen
Copy link
Contributor

@1ec5 There is a setter for URL in the core class, so it can be read-write as well.

Atm, this is blocked as the updates aren't handled properly yet. I think this might be related to #5701

@boundsj boundsj self-assigned this Sep 13, 2016
@boundsj
Copy link
Contributor

boundsj commented Sep 13, 2016

ref: #6264

@1ec5
Copy link
Contributor Author

1ec5 commented Sep 20, 2016

Unblocked by #6347.

@boundsj
Copy link
Contributor

boundsj commented Sep 21, 2016

Android implementation landed in #6054

This was referenced Oct 20, 2016
Closed
Merged
@boundsj
Copy link
Contributor

boundsj commented Oct 27, 2016

iOS implementation done in #6793

@boundsj boundsj closed this as completed Oct 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@boundsj boundsj

Labels
GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Milestone
ios-v3.4.0
Development

No branches or pull requests
3 participants
@boundsj @ivovandongen @1ec5