Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Class-specific paint properties in runtime styling API #5948

Closed
1ec5 opened this issue Aug 11, 2016 · 3 comments
Closed

Class-specific paint properties in runtime styling API #5948

1ec5 opened this issue Aug 11, 2016 · 3 comments
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 11, 2016

Per #5727 (comment), paint attributes are exposed, unparameterized, at the top level of each style layer class. For non-default, style class–specific paint properties, we should add an additional pair of getters and setters for each attribute. For example, the circleBlur property should be accompanied by -circleBlurForStyleClass: and -setCircleBlur:forStyleClass:.

/cc @frederoni @jfirebaugh

@jfirebaugh
Copy link
Contributor

What if we didn't expose class-specific paint properties in the SDK? Android doesn't, and I'm 95% sure that we'll be removing them from the style specification in a future revision.

@1ec5
Copy link
Contributor Author

1ec5 commented Sep 1, 2016

Style classes have been in limbo for well over a year. The point of this ticket is that, if we intend to keep style classes around, then we should make them usable. If they're deprecated, though, I agree that we should focus our efforts elsewhere.

@jfirebaugh
Copy link
Contributor

Let's focus our efforts elsewhere.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Development

No branches or pull requests

3 participants