Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Flat markers should have screen-centered vanishing point #5218

Closed
1ec5 opened this issue Jun 2, 2016 · 2 comments
Closed

Flat markers should have screen-centered vanishing point #5218

1ec5 opened this issue Jun 2, 2016 · 2 comments
Labels
Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android bug

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jun 2, 2016

As seen in #3276 (comment), the vanishing point for a flat marker view on a tilted map is always somewhere directly above the marker view. So in the screenshot above, the flag to the right is symmetrical across the y axis, whereas you’d expect both the left and right sides of the flag to parallel the north-south streets they’re being drawn atop:

device-2016-06-02-183106

If the perspective transformation is executed correctly, you shouldn’t be able to tell that the flag is a marker view. As you pan the map from side to side, the streets shouldn’t appear to be moving relative to the flag. In graphics terms, the vanishing point for the transform should be horizontally centered; it shouldn’t vary by the x position of the marker view.

Due to #5090, we haven’t run into this issue on iOS yet, but it’s something to be aware of.

/cc @tobrun @bleege @boundsj @friedbunny

@1ec5 1ec5 added bug Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android labels Jun 2, 2016
@1ec5 1ec5 changed the title Flat markers should have fixed vanishing point Flat markers should have screen-centered vanishing point Jun 2, 2016
@tobrun
Copy link
Member

tobrun commented Jun 3, 2016

Thank for the 👀 @1ec5, getting this in will probably require the addition of a container view since we need to be able to control the onDraw and do the projection ourselves. (instead of relying on setRotationX of the user provided view).

@tobrun
Copy link
Member

tobrun commented Oct 10, 2017

with #9782 we have deprecated MarkerView, closing.

@tobrun tobrun closed this as completed Oct 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android bug
Projects
None yet
Development

No branches or pull requests

2 participants