Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Too much drift pan resistance at z0–z1 #3655

Closed
1ec5 opened this issue Jan 21, 2016 · 10 comments
Closed

Too much drift pan resistance at z0–z1 #3655

1ec5 opened this issue Jan 21, 2016 · 10 comments
Labels
Android Mapbox Maps SDK for Android bug

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jan 21, 2016

At z0 and z1, if you flick the map, it gets caught on something and even bounces back. Possibly related to #3588.

/cc @friedbunny

@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS labels Jan 21, 2016
@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jan 25, 2016
@tobrun
Copy link
Member

tobrun commented Jan 25, 2016

FWIW noticing this on Android as well, adding Android label.

@1ec5
Copy link
Contributor Author

1ec5 commented Jan 25, 2016

Maybe it’s related to the call to unwrapLatLng() that I added in #3497. But it seems to work just fine for flyTo() (#3355).

@friedbunny
Copy link
Contributor

Another case of panning "bouncing back" is when the map is tilted and you drag downward on the top forcefully — the map will shoot downward, rather than upward.

@1ec5 1ec5 added this to the ios-v3.2.0 milestone Jan 29, 2016
@tobrun
Copy link
Member

tobrun commented Mar 6, 2016

we should maybe take the time to git bisect this issue to pinpoint it to a specific commit?

@tobrun
Copy link
Member

tobrun commented Mar 12, 2016

I was able to pinpoint it to this commit.

d26b956a48dc2da9333b40d8d2c4371c63b372a2 is the first bad commit
commit d26b956a48dc2da9333b40d8d2c4371c63b372a2
Author: Minh Nguyễn <[email protected]>
Date:   Sun Jan 10 17:28:21 2016 -0800

    [core] Cleaned up Transform

    Eliminated many redundant methods on Transform. Minimized usage of TransformState::x and TransformState::y. Added convenient constructors for AnimationOptions. When scaling, passing in view’s origin as the anchor no longer anchors the scaling operation at the view’s center. To specify no anchor, use NaN.

    Increased precision of worldSize(), now that it’s used much more heavily in transform methods.

:040000 040000 8f0b3b83dabb79ade17c755ba2937739429665ac 02de4fae20c3c2ed0bc85ebaaf9efe3e85f5f595 M  include
:040000 040000 183164f0f4d4ffd934d838d6e136af4d1780797f a3ebc9aeece1bcbdca2c3be0df87b54a86524d1d M  platform
:040000 040000 4f0133c1a47c3e37cff1af2606a64dfdeee6c68a 56b71bce1645fc572926fef5031b6c14958cf4d2 M  src

@1ec5
Copy link
Contributor Author

1ec5 commented Mar 12, 2016

This was fixed in #4214.

@1ec5 1ec5 closed this as completed Mar 12, 2016
@tobrun
Copy link
Member

tobrun commented Mar 12, 2016

gif-keyboard-12488273348198164312

@tobrun
Copy link
Member

tobrun commented Mar 13, 2016

I retested on master with d64652f, still an issue. See an example here.

@tobrun tobrun reopened this Mar 13, 2016
@1ec5 1ec5 modified the milestones: android-v4.0.0, ios-v3.3.0 Mar 13, 2016
@1ec5 1ec5 removed the iOS Mapbox Maps SDK for iOS label Mar 13, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Mar 13, 2016

I don’t have access to that video, but I can’t reproduce the original issue in a980f72 on iOS or OS X. Maybe what you’re seeing is unrelated?

@tobrun
Copy link
Member

tobrun commented Mar 13, 2016

I just saw a difference between what I had seen during git bisecting and what we have now on master. Thinking a bit more about this I don't feel this is worth putting more time into. There are other priorities that are more important. Going to close.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android bug
Projects
None yet
Development

No branches or pull requests

3 participants