You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Running cmake -G Xcode . -DCMAKE_SYSTEM_NAME=Darwin results in an Xcode project whose targets have the MACOSX_DEPLOYMENT_TARGET build setting unset. This causes the build products to default to a minimum deployment target that is the newest macOS SDK version supported by the current version of Xcode. As on iOS in #16241, the minimum deployment target should instead be the oldest version supported by the macOS map SDK, which is macOS 10.11.0.
This isn’t a problem on iOS, because something causes this code to set the minimum deployment target:
macOS map SDK v0.15.0 crashes on launch on macOS 10.11–10.14 because it was built on macOS 10.15 and has no explicit minimum deployment target. Examples of this crash include mapbox/mapbox-gl-native-ios#195 and mapbox/mapbox-gl-native-ios#205.
Running
cmake -G Xcode . -DCMAKE_SYSTEM_NAME=Darwin
results in an Xcode project whose targets have theMACOSX_DEPLOYMENT_TARGET
build setting unset. This causes the build products to default to a minimum deployment target that is the newest macOS SDK version supported by the current version of Xcode. As on iOS in #16241, the minimum deployment target should instead be the oldest version supported by the macOS map SDK, which is macOS 10.11.0.This isn’t a problem on iOS, because something causes this code to set the minimum deployment target:
mapbox-gl-native/platform/ios/ios.cmake
Lines 3 to 5 in 488e550
But similar code in the macOS configuration doesn’t run:
mapbox-gl-native/platform/macos/macos.cmake
Lines 1 to 3 in 8229bd1
/cc @mapbox/maps-ios @mapbox/gl-native
The text was updated successfully, but these errors were encountered: