Fill color is too light

[kkaefer]

Our expected image is black rgb(0, 0, 0):

However, we're getting rgb(1, 1, 1):

(ignore the border around the tile)

[kkaefer]

Seeing this on OS X 10.10.3 with a nVidia GeForce GT 650M.

[kkaefer]

This may be due to sRGB bits:

[tmpsantos]

I get the same here on Ubuntu 15.04 Vivid with an ATI Radeon HD 6850.

[tmpsantos]

I get the same here on Ubuntu 15.04 Vivid with an ATI Radeon HD 6850.

Nah, my bad. On fill-color/default here only the borders are different.

[kkaefer]

Confirmed that this is the cause of images appearing too dark or bright compared to the reference image; the actual image data is not different. We set the rendering intent to default, but it looks like Core Graphics is still outputting perceptual, or ICC color profiles.

[jfirebaugh]

@kkaefer Can you test this and #1542 against https://github.com/mapbox/mapbox-gl-test-suite/compare/update -- I updated the tests there using current gl-js and can no longer replicate either. Maybe it is due to a library on my machine being upgraded since the expected results were last generated.

[kkaefer]

@jfirebaugh #1542 (comment)

[jfirebaugh]

@kkaefer Can you test this again? I think it was fixed by either always running headless tests in node, or by #3083.