Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

MGLMapSnapshotter.loading is always false #209

Closed
1ec5 opened this issue Mar 13, 2020 · 0 comments · Fixed by #210
Closed

MGLMapSnapshotter.loading is always false #209

1ec5 opened this issue Mar 13, 2020 · 0 comments · Fixed by #210
Assignees
Labels
bug Something isn't working ios macOS

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 13, 2020

MGLMapSnapshotter.loading’s getter always returns NO. Nothing within the MGLMapSnapshotter implementation ever sets the synthesized ivar, so it maintains the default value of NO.

/**
Indicates whether a snapshot is currently being generated.
*/
@property (nonatomic, readonly, getter=isLoading) BOOL loading;

This regression was introduced in 315a9e3 in mapbox/mapbox-gl-native#12355. The sole references to this property were removed in favor of an internal property that was never synchronized with loading.

/cc @mapbox/maps-ios

@1ec5 1ec5 added bug Something isn't working ios macOS labels Mar 13, 2020
@1ec5 1ec5 self-assigned this Mar 13, 2020
@1ec5 1ec5 closed this as completed in #210 Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ios macOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant