-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map.panBy and Point.convert API #8968
Labels
Comments
Looks like we want to bring this PR in to fix this: mapbox/point-geometry#12 |
Not sure worth opening another issue? But I just noticed a similar API vs implementation discrepancy for |
@ryanhamley Thanks, should've searched better! But.. I think LngLatBounds still has bugs. I'll post some examples in that thread. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
map.panBy
specifies that its first argument can be aPointLike
object. Though if you pass in an{x, y}
literal it fails incamera.js
due to thePoint.convert(offset).mult()
call that assumes that the output fromPoint.convert
is a real Point instance, which is not whatPoint.convert
spec actually says, it will only convert Array to Point, other objects (literals) unchanged./Fredrik Blomqvist
The text was updated successfully, but these errors were encountered: