Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken benchmarks build (or drop React) #8064

Closed
mourner opened this issue Mar 21, 2019 · 1 comment · Fixed by #8066
Closed

Fix broken benchmarks build (or drop React) #8064

mourner opened this issue Mar 21, 2019 · 1 comment · Fixed by #8066

Comments

@mourner
Copy link
Member

mourner commented Mar 21, 2019

After merging publisher-production branch with the docs upgrades, yarn run build-benchmarks started failing, with rollup-plugin-commonjs complaining about unexpected token in react-dom (although the exact location is bogus — there's nothing suspicious there). This package upgraded from v16.0.0 to v16.7.0, and something in between those versions broke the setup. I tracked it down specifically to v16.4.0, starting from which the builds fail. Also confimed that the builds still fail in v16.8.2.

This is really cryptic and I don't have yet good ideas about what causes this, but I think the best fix would be to refactor and cut out all this React bloat from benchmarks for good. 😡

@mourner
Copy link
Member Author

mourner commented Mar 23, 2019

I think I found the likely culprit of the original issue — it's rollup-plugin-unassert breaking on some code because of an outdated Acorn dependency — the plugin hasn't been updated in a while. I'll see if I can get maintenance access to the repo and make a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant