Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expressions convert functions: output linear interpolation? #6840

Closed
nickidlugash opened this issue Jun 20, 2018 · 3 comments · Fixed by #9107
Closed

Expressions convert functions: output linear interpolation? #6840

nickidlugash opened this issue Jun 20, 2018 · 3 comments · Fixed by #9107

Comments

@nickidlugash
Copy link

In the functions to convert deprecated functions to expressions, we are converting functions with type exponential and base 1 to interpolation expressions with type ["exponential", 1]. While this is the most exact conversion, would it be more useful to convert these to type ["linear"]?

/cc @anandthakker @jfirebaugh @tristen @aparlato

@Jo-IE
Copy link
Contributor

Jo-IE commented Dec 5, 2019

Hi! I would like to work on this :)

I have a quick clarification:
So when base equals 1, we would just change the expression to look like this expression = ['interpolate', ['linear'], ['number', ['get', parameters.property]]]

and this should be done in both the convertPropertyFunction and the convertZoomFunction?

Thank you!

@tristen
Copy link
Member

tristen commented Dec 5, 2019

👋 @Jo-IE

So when base equals 1, we would just change the expression to look like this expression = ['interpolate', ['linear'], ['number', ['get', parameters.property]]]

Correct!

and this should be done in both the convertPropertyFunction and the convertZoomFunction?

Correct too!

@Jo-IE
Copy link
Contributor

Jo-IE commented Dec 5, 2019

Thank you @tristen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants