Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why offset of icons not defined in sprite.json #5369

Closed
strech345 opened this issue Sep 28, 2017 · 2 comments
Closed

Why offset of icons not defined in sprite.json #5369

strech345 opened this issue Sep 28, 2017 · 2 comments

Comments

@strech345
Copy link

because offset of sprite depends on each elements size i'm wondering why it isn't definded in sprite.json file. If i have different icon sizes i've to change it on js level for every icon. For me this didn't make sense.
So is it possible to define it in sprite.json otherwise why not?

Thanks

@jfirebaugh
Copy link
Contributor

In some cases, the offset is dependent on the type of feature being displayed, or other style-related considerations, rather than the icon itself, so we chose to make this as flexible as possible.

@strech345
Copy link
Author

Would it not nice to have it also in sprite.json as default and let the possibility to change it dynamically on js? I doesn't understand why i have to think about this parameter if i want to use some icon. For me it is a property which describe the icon like all the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants